Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix render_tuple with coerce #620

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix render_tuple with coerce #620

merged 1 commit into from
Dec 9, 2024

Conversation

kmsquire
Copy link
Collaborator

@kmsquire kmsquire commented Dec 5, 2024

We were not properly escaping quotes when rendering tuples, leading to a SyntaxError.

Fixes #619.

We were not properly escaping quotes when rendering tuples,
leading to a SyntaxError.
@kmsquire kmsquire self-assigned this Dec 5, 2024
@kmsquire kmsquire requested a review from yukinarit December 5, 2024 22:39
@kmsquire kmsquire added the bug Bug report or fix label Dec 5, 2024
Copy link
Owner

@yukinarit yukinarit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@yukinarit yukinarit merged commit b1acb5e into main Dec 9, 2024
7 checks passed
@yukinarit yukinarit deleted the feature/fix-render-tuple branch December 9, 2024 14:29
github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report or fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

render tuple does not properly escape quotes when using coerce
2 participants